Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show error message if config file missing #3

Merged
merged 5 commits into from
Nov 11, 2018

Conversation

chardos
Copy link
Contributor

@chardos chardos commented Nov 7, 2018

Currently, if playroom.config.js is missing, it will throw an ambiguous error:

(node:21821) UnhandledPromiseRejectionWarning: AssertionError [ERR_ASSERTION]: missing path
    at Module.require (internal/modules/cjs/loader.js:596:3)
    at require (internal/modules/cjs/helpers.js:11:18)
    at /Users/richardnew/git/seek-ads/node_modules/playroom/bin/cli.js:58:18
    at <anonymous>
(node:21821) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:21821) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

The README.md does cover what is needed, however since I bumped into this error myself, I thought a helpful hint may help the next person who neglects to RTFM.

bin/cli.js Outdated Show resolved Hide resolved
bin/cli.js Outdated Show resolved Hide resolved
markdalgleish and others added 3 commits November 8, 2018 08:42
Co-Authored-By: chardos <chardos@users.noreply.github.com>
Co-Authored-By: chardos <chardos@users.noreply.github.com>
@markdalgleish markdalgleish changed the title Give error message if config file missing fix: Show error message if config file missing Nov 8, 2018
@markdalgleish markdalgleish merged commit 7e9db88 into seek-oss:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants