Add favicon to Playroom site #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 14678c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mrm007
reviewed
Dec 17, 2023
Co-authored-by: Remus Mate <3297808+mrm007@users.noreply.github.com>
mrm007
approved these changes
Dec 18, 2023
david10sing
reviewed
Dec 19, 2023
| @@ -163,6 +167,7 @@ module.exports = async (playroomConfig, options) => { | |||
| chunksSortMode: 'none', | |||
| chunks: ['index'], | |||
| filename: 'index.html', | |||
| favicon: 'images/favicon.png', | |||
There was a problem hiding this comment.
Could this have come from playroomConfig? Could this be coming from a public folder too. But offering it in the playroomConfig would make it more flexible.
Currently getting an error when building playroom.
There was a problem hiding this comment.
Hey David, could you log the error as an Issue with a reproduction? Thanks!
There was a problem hiding this comment.
I'm getting an error too:
Error: HtmlWebpackPlugin: could not load file /<path-to-project>/images/favicon.png
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a little hackathon project.