Remove dependency on current-git-branch
#335
Conversation
🦋 Changeset detectedLatest commit: 8dc4435 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| */ | ||
| const getGitBranch = () => { | ||
| try { | ||
| return execSync('git branch --show-current').toString().trim(); |
There was a problem hiding this comment.
I've previously been burnt by OS differences when running raw child_process commands.
Is this something we should worry about?
I believe current-git-branch was using execa which builds in some "Make work on Windows" stuff.
There was a problem hiding this comment.
I think all of the stuff execa (via cross-spawn) solves as far as Windows is concerned is irrelevant for this very simple command. I've just tested this on my Windows machine in both Cmd and PowerShell, and it worked fine.
Replaces
current-git-branch, a relatively simple, yet likely unmaintained package, with a call togit branch --show-current.