Replace query-string dependency with URLSearchParams
#336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6cbbc72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
commented
Mar 2, 2024
Comment on lines
-22
to
+30
| const { themeName, code } = useParams((rawParams) => ({ | ||
| themeName: | ||
| typeof rawParams.themeName === 'string' ? rawParams.themeName : '', | ||
| code: typeof rawParams.code === 'string' ? rawParams.code : '', | ||
| })); | ||
| const { themeName, code } = useParams((rawParams) => { | ||
| const rawThemeName = rawParams.get('themeName'); | ||
| const rawCode = rawParams.get('code'); | ||
|
|
||
| return { | ||
| themeName: rawThemeName || '', | ||
| code: rawCode || '', | ||
| }; | ||
| }); |
There was a problem hiding this comment.
query-string's API returned a single value or an array, but URLSearchParams' .get API returns string | null, so there's no need for a typeof check here anymore.
jahredhope
approved these changes
Mar 2, 2024
askoufis
commented
Mar 2, 2024
Comment on lines
23
to
+30
| try { | ||
| return queryString.parse( | ||
| return new URLSearchParams( | ||
| playroomConfig.paramType === 'hash' | ||
| ? location.hash.replace(/^#/, '') | ||
| : location.search | ||
| ); | ||
| } catch (err) { | ||
| return {}; | ||
| return new URLSearchParams(); |
There was a problem hiding this comment.
This try catch might not even be needed anymore since AFAICT URLSearchParams constructor never throws. I couldn't make it throw on any input, and a cursory glance at the spec didn't mention throwing. But probably better to be safe than sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform-native
URLSearchParamshas broad browser support, so we don't really have a need forquery-stringanymore.