Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stack component to use CSS gap #355

Merged
merged 7 commits into from
May 28, 2024
Merged

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented May 23, 2024

  • Update Stack component to use CSS gap, simplifying the component
  • Remove unused Divider component
  • Callout browser policy in README

@felixhabib felixhabib requested a review from a team as a code owner May 23, 2024 04:30
Copy link

changeset-bot bot commented May 23, 2024

🦋 Changeset detected

Latest commit: e5aecb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
playroom Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should have a changeset. It's something that benefits the UI, so should be released. Don't know how to word it though, as it's not really worth detailing implementation changes. 🤔

@felixhabib felixhabib marked this pull request as draft May 24, 2024 02:07
@felixhabib felixhabib requested a review from askoufis May 24, 2024 02:07
@felixhabib felixhabib marked this pull request as ready for review May 24, 2024 02:08
Merged origin/master into stack with flexgap
@askoufis
Copy link
Contributor

Branch is not up to date, but you can still merge for some reason.
image

I think that should be disabled in the repo settings though 🤔

'playroom': minor
---

Optimise Playroom UI performance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't really call out this as a perf change. Maybe it is just worth saying something like Use CSS gap for spacing or something.

I do think it's worth adding a note to the README saying that Playroom will only ever utilize features supported by all browers, but it assumes you have the latest stable version of any of the major browsers.

@felixhabib felixhabib marked this pull request as draft May 28, 2024 01:04
@felixhabib felixhabib marked this pull request as ready for review May 28, 2024 04:13
@felixhabib felixhabib requested a review from askoufis May 28, 2024 04:14
@felixhabib felixhabib merged commit 384810e into master May 28, 2024
6 checks passed
@felixhabib felixhabib deleted the stack-with-flexgap branch May 28, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants