-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Stack
component to use CSS gap
#355
Conversation
🦋 Changeset detectedLatest commit: e5aecb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should have a changeset. It's something that benefits the UI, so should be released. Don't know how to word it though, as it's not really worth detailing implementation changes. 🤔
Merged origin/master into stack with flexgap
6ec295f
to
9b5021b
Compare
.changeset/khaki-seahorses-fly.md
Outdated
'playroom': minor | ||
--- | ||
|
||
Optimise Playroom UI performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't really call out this as a perf change. Maybe it is just worth saying something like Use CSS gap for spacing
or something.
I do think it's worth adding a note to the README saying that Playroom will only ever utilize features supported by all browers, but it assumes you have the latest stable version of any of the major browsers.
Stack
component to use CSSgap
, simplifying the componentDivider
component