Replace "/" from Renovate Branch Prefix with "--" to be URL Safe #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahredhope
changed the title
72636c
added a commit
to seek-oss/skuba
that referenced
this pull request
Nov 7, 2022
72636c
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branches can be used as identifiers for things like preview environments.
This can mean that the branch name appears in URLs, either as subdomains, paths or query parameters.
cool-feature.example.comexample.com/cool-featureexample.com/path?version=cool-featureIn these cases it's nice to have URLs with limited special characters.
Current
Currently renovate branches have
/added which results in URLs like:renovate%2Fcool-feature.example.comexample.com/renovate%2Fcool-featureexample.com/path?version=renovate%2Fcool-featureWith Change
With this change it'll instead use
--:renovate--cool-feature.example.comexample.com/renovate--cool-featureexample.com/path?version=renovate--cool-featureChange
Default for Branch Prefix is
renovate/This PR changes is to
renovate--Precedence
This aligns to the SEEK Renovate config that sets the value to the same: https://github.com/seek-oss/renovate-config-seek/blob/eb02ac2d5b72828c9365020a5b44f37ab5921323/package.json#L28
This has been raised previously and was closed: #7 though allowed re-open if it's still an issue which I believe it is.