Add missing fixture dev dep, small code removal (#771)

seek-oss · Apr 17, 2023 · 5f44ecd · 5f44ecd
1 parent 1acc7c9
commit 5f44ecd
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/fixtures/braid-design-system/package.json b/fixtures/braid-design-system/package.json
@@ -7,5 +7,8 @@
     "react": "^17.0.1",
     "react-dom": "^17.0.1",
     "sku": "workspace:*"
+  },
+  "devDependencies": {
+    "@vanilla-extract/css": "^1.0.0"
   }
 }
diff --git a/packages/sku/config/storybook/storybookWebpackConfig.js b/packages/sku/config/storybook/storybookWebpackConfig.js
@@ -1,22 +1,12 @@
-const webpack = require('webpack');
 const { paths } = require('../../context');
 const find = require('lodash/find');
 const { merge: webpackMerge } = require('webpack-merge');
-const isCI = require('../../lib/isCI');
 const makeWebpackConfig = require('../webpack/webpack.config');
 const { resolvePackage } = require('../webpack/utils/resolvePackage');
 
 const hot = process.env.SKU_HOT !== 'false';
 
 module.exports = ({ config }, { isDevServer }) => {
-  if (isCI) {
-    // Remove noisy progress plugin in CI, currently no official option to disable
-    // https://github.com/storybookjs/storybook/issues/1260#issuecomment-308036626
-    config.plugins = config.plugins.filter(
-      (plugin) => !(plugin instanceof webpack.ProgressPlugin),
-    );
-  }
-
   const clientWebpackConfig = find(
     makeWebpackConfig({
       isIntegration: true,

diff --git a/packages/sku/context/index.js b/packages/sku/context/index.js
@@ -151,7 +151,6 @@ const paths = {
     : null,
   serverEntry: getPathFromCwd(skuConfig.serverEntry),
   public: getPathFromCwd(skuConfig.public),
-  relativeTarget: skuConfig.target,
   target: getPathFromCwd(skuConfig.target),
   relativeTarget: skuConfig.target,
   publicPath: isStartScript ? '/' : publicPath,

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml