Skip to content

Commit

Permalink
Bump minimum node version to 18.12 (#805)
Browse files Browse the repository at this point in the history
  • Loading branch information
askoufis committed May 26, 2023
1 parent 7de96d0 commit b75e6ec
Show file tree
Hide file tree
Showing 20 changed files with 291 additions and 239 deletions.
20 changes: 20 additions & 0 deletions .changeset/tidy-scissors-roll.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
'sku': major
---

Require Node.js 18.12+

**BREAKING CHANGE**

Node 14 has already reached end of life as of April 2023, and Node.js 16 had its end of life date [brought forward to September 2023][node 16 eol], so in the interest of preventing another breaking change in 4 months time, we're pre-emptively dropping support for Node.js 16 in addition to Node.js 14.
We've chosen to support Node.js versions from v18.12 onwards as this version was the first [Node.js 18 LTS release][node 18.12 release].

Consider upgrading the Node.js version for your project across:

- `.nvmrc`
- `package.json#/engines/node`
- `@types/node` package version
- CI/CD configuration (`.buildkite/pipeline.yml`, `Dockerfile`, etc.)

[node 16 eol]: https://nodejs.org/en/blog/announcements/nodejs16-eol
[node 18.12 release]: https://nodejs.org/en/blog/release/v18.12.0
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.20.0
18.16.0
2 changes: 1 addition & 1 deletion fixtures/assertion-removal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"react-dom": "^18.2.0"
},
"devDependencies": {
"@types/node": "^16.0.0",
"@types/node": "^18.0.0",
"@types/react": "^18.2.3",
"@types/react-dom": "^18.2.3",
"dedent": "^0.7.0",
Expand Down
7 changes: 2 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
"name": "@sku-private/monorepo",
"private": true,
"description": "Front-end development toolkit, powered by Webpack, Babel, CSS Modules, Less and Jest",
"engines": {
"node": ">=14.15"
},
"scripts": {
"postinstall": "node ./postinstall.js",
"prepare": "husky install",
Expand Down Expand Up @@ -55,7 +52,7 @@
"husky": "^8.0.3",
"jest": "^29.0.0",
"jest-environment-jsdom": "^29.0.0",
"jest-puppeteer": "^8.0.6",
"jest-puppeteer": "^9.0.0",
"jest-watch-typeahead": "^2.2.0",
"lint-staged": "^11.1.1",
"prettier": "^2.8.8",
Expand All @@ -64,7 +61,7 @@
"rimraf": "^5.0.0"
},
"volta": {
"node": "16.20.0"
"node": "18.16.0"
},
"skuSkipPostInstall": true,
"skuSkipConfigure": true,
Expand Down
8 changes: 4 additions & 4 deletions packages/sku/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"sku": "./bin/sku.js"
},
"engines": {
"node": ">=14.15"
"node": ">=18.12"
},
"scripts": {
"postinstall": "node ./scripts/postinstall.js"
Expand Down Expand Up @@ -54,11 +54,11 @@
"@vocab/webpack": "^1.2.1",
"autoprefixer": "^10.3.1",
"babel-jest": "^29.0.0",
"babel-loader": "^8.2.2",
"babel-loader": "^9.1.2",
"babel-plugin-add-react-displayname": "^0.0.5",
"babel-plugin-dynamic-import-node": "^2.3.3",
"babel-plugin-macros": "^3.1.0",
"babel-plugin-module-resolver": "^4.1.0",
"babel-plugin-module-resolver": "^5.0.0",
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
"babel-plugin-unassert": "^3.1.0",
"browserslist": "^4.16.1",
Expand Down Expand Up @@ -120,7 +120,7 @@
"traverse": "^0.6.6",
"tree-kill": "^1.2.1",
"typescript": "^4.5.0",
"validate-npm-package-name": "^4.0.0",
"validate-npm-package-name": "^5.0.0",
"webpack": "^5.52.0",
"webpack-bundle-analyzer": "^4.6.1",
"webpack-dev-server": "4.11.1",
Expand Down
Loading

0 comments on commit b75e6ec

Please sign in to comment.