-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook): Add 'build-storybook' command #333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hscgavin
requested review from
mattcompiles,
markdalgleish and
michaeltaranto
February 28, 2019 02:41
markdalgleish
approved these changes
Mar 4, 2019
Nice one—might even start using this on Braid 👏👏👏 |
markdalgleish
changed the title
feat(storybook): Add build storybook script
feat(storybook): Add 'build-storybook script
Mar 4, 2019
markdalgleish
changed the title
feat(storybook): Add 'build-storybook script
feat(storybook): Add 'build-storybook' command
Mar 4, 2019
mengtzu
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are very well commented, I understand the reasoning behind some otherwise weird looking code 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build the Storybook, first add the following npm script:
Then run
npm run build-storybook
.By default, Storybook assets are generated in the
dist-storybook
directory in your project root folder. If you would like to specify a custom target directory, you can provide it via thestorybookTarget
option insku.config.js
: