Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): Add 'build-storybook' command #333

Merged
merged 12 commits into from
Mar 4, 2019
Merged

Conversation

hscgavin
Copy link
Contributor

@hscgavin hscgavin commented Feb 28, 2019

To build the Storybook, first add the following npm script:

{
  "scripts": {
    "build-storybook": "sku build-storybook"
  }
}

Then run npm run build-storybook.

By default, Storybook assets are generated in the dist-storybook directory in your project root folder. If you would like to specify a custom target directory, you can provide it via the storybookTarget option in sku.config.js:

module.exports = {
  storybookTarget: './dist/storybook'
};

@markdalgleish
Copy link
Member

Nice one—might even start using this on Braid 👏👏👏

@markdalgleish markdalgleish changed the title feat(storybook): Add build storybook script feat(storybook): Add 'build-storybook script Mar 4, 2019
@markdalgleish markdalgleish changed the title feat(storybook): Add 'build-storybook script feat(storybook): Add 'build-storybook' command Mar 4, 2019
Copy link
Contributor

@mengtzu mengtzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are very well commented, I understand the reasoning behind some otherwise weird looking code 👍 :shipit:

@markdalgleish markdalgleish merged commit 2d10ec1 into master Mar 4, 2019
@markdalgleish markdalgleish deleted the build-storybook branch March 4, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants