fix: Remove sku prefix from Loadable Components import #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this PR as we are changing our approach a little. May not require a breaking version. Stay tuned. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Loadable Components import is no longer prefixed with
sku/, see v9 Migration guide.Migration Guide
Dynamic imports using
@loadableIf your application features code splitting, you will need to update your Loadable Components imports to remove the
sku/prefix. For example:Braid Design System consumers
If you are consuming
braid-design-system, you will need to ensure that you are on v0.0.63 or newer as it depends on this release.