New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playroom): Add Playroom support #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we regen the yarn.lock
completely? Seems like it's in a strange state with some dependencies.
@@ -1,5 +1,6 @@ | |||
const supportedBrowsers = require('browserslist-config-seek'); | |||
const path = require('path'); | |||
const isTypeScript = require('../lib/isTypeScript'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isTypeScript
is actually a function. However, it probably should be a value because otherwise, we may call it multiple times and it's not zero cost.
This PR adds Playroom support via the
sku playroom
andsku build-playroom
commands.