Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Prettier v2 #463

Merged
merged 8 commits into from
Mar 24, 2020
Merged

Update to Prettier v2 #463

merged 8 commits into from
Mar 24, 2020

Conversation

mattcompiles
Copy link
Contributor

Prettier v2 requires node > 10.13.0 so also bumping minimum supported node version, making this PR a breaking change.

@mattcompiles mattcompiles requested a review from a team as a code owner March 24, 2020 00:21
@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2020

🦋 Changeset is good to go

Latest commit: acfa051

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -7,7 +7,7 @@
"sku": "./bin/sku.js"
},
"engines": {
"node": ">=8.6"
"node": ">=10.13.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth doing a lock file upgrade on the back of this. Thoughts?

Copy link
Contributor

@michaeltaranto michaeltaranto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty

@mattcompiles mattcompiles merged commit f1e4276 into master Mar 24, 2020
@mattcompiles mattcompiles deleted the update-prettier branch March 24, 2020 02:38
@seek-oss-ci seek-oss-ci mentioned this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants