-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Prettier v2 #463
Conversation
🦋 Changeset is good to goLatest commit: acfa051 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -7,7 +7,7 @@ | |||
"sku": "./bin/sku.js" | |||
}, | |||
"engines": { | |||
"node": ">=8.6" | |||
"node": ">=10.13.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth doing a lock file upgrade on the back of this. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty
Prettier v2 requires node > 10.13.0 so also bumping minimum supported node version, making this PR a breaking change.