Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sku-telemetry #495

Merged
merged 9 commits into from Apr 17, 2020
Merged

Add support for sku-telemetry #495

merged 9 commits into from Apr 17, 2020

Conversation

mattcompiles
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2020 •
edited

🦋 Changeset is good to go

Latest commit: dd46afd

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mattcompiles mattcompiles marked this pull request as ready for review April 16, 2020 05:19
@mattcompiles mattcompiles requested a review from a team as a code owner April 16, 2020 05:19
@mattcompiles mattcompiles changed the title Telemetry Add metric tracking support Apr 16, 2020
markdalgleish
markdalgleish approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some feedback around the changeset, but nothing to block an approval over. This is great 👍

@markdalgleish markdalgleish changed the title Add metric tracking support Add support for sku-telemetry Apr 17, 2020
jahredhope
jahredhope approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@jahredhope jahredhope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. One suggestion.

scripts/build-ssr.js Outdated Show resolved Hide resolved
@mattcompiles mattcompiles merged commit 07f3fc7 into master Apr 17, 2020
@mattcompiles mattcompiles deleted the telemetry branch April 17, 2020 02:26
@seek-oss-ci seek-oss-ci mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish approved these changes

@jahredhope jahredhope jahredhope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattcompiles @markdalgleish @jahredhope