fix(config): add ability to serve generated static files for ssr dev #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcompiles
reviewed
Sep 7, 2017
|
@MattsJones sure, we're assuming outside dev the files are probably on an s3 bucket somewhere or otherwise not served by our express server, as I understand it. |
|
@MattsJones added dev check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message For Review
Adds serving for static files in the root directory for server side rendering.
REASON FOR CHANGE:
Without this, when using SSR in dev requests for
main.js,styles.cssand their friends will simply return the output of the render callback. In most apps this will be the rendered HTML intended for a 404.