Fix root resolution within .css.ts files during tests
#741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3916036 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benjervis
approved these changes
Feb 24, 2023
mrm007
reviewed
Feb 24, 2023
| @@ -10,6 +11,7 @@ module.exports = { | |||
| testEnvironment: 'jsdom', | |||
| setupFilesAfterEnv: paths.setupTests, | |||
| prettierPath: require.resolve('prettier'), | |||
| modulePaths: rootResolution ? [cwd()] : undefined, | |||
There was a problem hiding this comment.
Does this work?
Suggested change
| modulePaths: rootResolution ? [cwd()] : undefined, | |
| modulePaths: rootResolution ? ['<rootDir>'] : undefined, |
There was a problem hiding this comment.
It probably does, but I wanted to keep it consistent with the babel transform root, which we get from the result of cwd.
sku/config/babel/babelConfig.js
Line 20 in f1c41a1
I think if you're running sku test via your package manger, this will end up being your project root anyway.
michaeltaranto
approved these changes
Feb 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the VE babel plugin with the VE jest transform resulted in
.css.tsfiles no longer going through our babel transformation stack during jest tests. This ended up breaking root resolution (importing fromsrc/*) within.css.tsfiles during tests.Luckily, jest has a config value just for this:
modulePaths. Setting this to the result ofcwdwhenrootResolutionis true (like we do in the babel transform stack) fixes the issue.