Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libraryFile configuration option #755

Merged
merged 7 commits into from
Mar 30, 2023
Merged

Add libraryFile configuration option #755

merged 7 commits into from
Mar 30, 2023

Conversation

kjots
Copy link
Contributor

@kjots kjots commented Mar 30, 2023

  • Add a new option, libraryFile, to allow the file name of a library to be specified in the sku configuration.
  • Fallback to the existing behaviour of using libraryName for file name of the library if libraryFile is not specified.
  • Update types and documentation for new configuration option.
  • Add test case and fixture for new configuration option.

@kjots kjots requested a review from a team as a code owner March 30, 2023 00:39
@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023

🦋 Changeset detected

Latest commit: f2eb84d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

fixtures/library-file/src/styles.treat.ts Outdated Show resolved Hide resolved
packages/sku/config/webpack/webpack.config.js Show resolved Hide resolved
.changeset/many-toys-search.md Outdated Show resolved Hide resolved
kjots and others added 2 commits March 30, 2023 13:40
docs/docs/libraries.md Outdated Show resolved Hide resolved
@kjots kjots merged commit 40022c8 into master Mar 30, 2023
2 checks passed
@kjots kjots deleted the config-library-file branch March 30, 2023 22:00
@seek-oss-ci seek-oss-ci mentioned this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants