Remove some usage of promisify, replace fs-extra usage with plain fs
#770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 564b44e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jahredhope
reviewed
Apr 14, 2023
kjots
reviewed
Apr 14, 2023
jahredhope
reviewed
Apr 14, 2023
jahredhope
reviewed
Apr 14, 2023
mrm007
reviewed
Apr 14, 2023
mrm007
approved these changes
Apr 14, 2023
askoufis
changed the title
promisify, replace some fs-extra usage with plain fspromisify, replace fs-extra usage with plain fs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent, and not so recent, dependency updates (e.g. #768), some packages now export async versions of their functions, removing the need to use
promisifyin some situations.Also, some
fs-extrausage can be replaced with plainfsorfs/promises.There are somefs-extrafunctions that don't have equivalents in plainfs, particularlyensureExists, but they could be recreated if need be, and we could potentially remove our dependency onfs-extra, if there's any value in doing that.After addressing the comment below,
fs-extrahas been removed as a dependency 🎉 .