-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fixture dev deps #772
Fix fixture dev deps #772
Conversation
|
@@ -13,7 +13,7 @@ const skuRender: Render = { | |||
</SkuProvider>, | |||
), | |||
|
|||
renderDocument: ({ app, headTags, bodyTags }) => dedent` | |||
renderDocument: ({ app, headTags, bodyTags }) => dedent/* html */ ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pro tip: if you alias dedent
to html
Prettier will format the markup inside the string tag, like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's neat.
As mentioned here, fixture dev deps weren't really correct. This PR addresses that by:
sku
to a dev dep for all fixturesdedent
as a dev dep to relevant fixturesI also added
/* html */
comments to template strings in fixtures so IDEs show correct syntax highlighting.