Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to eslint-config-seek v11.0.0 #779

Merged
merged 6 commits into from
Apr 21, 2023
Merged

Conversation

mrm007
Copy link
Contributor

@mrm007 mrm007 commented Apr 21, 2023

This version of the ESLint config adds additional rules enforcing consistent type imports/exports, as explained in this article.

@mrm007 mrm007 requested a review from a team as a code owner April 21, 2023 02:32
@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2023

🦋 Changeset detected

Latest commit: b700927

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +24 to +28
// react isn't a dependency of the monorepo, so we need to tell ESLint which version to use
react: {
version: require('./packages/sku/node_modules/react/package.json')
.version,
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only relevant change is this section.

@mrm007 mrm007 merged commit 7a0dd11 into master Apr 21, 2023
2 checks passed
@mrm007 mrm007 deleted the bump-eslint-config-seek branch April 21, 2023 04:02
@seek-oss-ci seek-oss-ci mentioned this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants