Fix sku init on Windows
#833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 48e6ff2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mrm007
approved these changes
Jun 9, 2023
Co-authored-by: Remus Mate <rmate@seek.com.au>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npx sku init <name>was broken on windows. The app folder would be created, but thesrcdirectory containing the sku template files was never created.This was occurring because
fast-globexpects/as a path separator, so windows paths with\are interpreted as paths with escaped characters, resulting in an empty array from the glob. Theinitscript uses__dirnameto drive the template creation, so by ensuring we convert it to a posix path, and use the posix implementations of the path methods, the glob should receive correct input.We currently do not run our CI on windows agents, and there are no plans to do so in the future. However, this fix has been tested on my personal windows machine, as well as on the widnows machine of the user that reported the bug.