Improve compile package detection in PNPM apps #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 78b90ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
changed the title
jahredhope
approved these changes
Jun 22, 2023
mrm007
reviewed
Jun 22, 2023
mrm007
approved these changes
Jun 23, 2023
|
Tested in an app and metropolis ✅ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables sku to detect compile packages inside the PNPM virtual store (
node_modules/.pnpm). The current implementation of compile package detection only finds@seekscoped packages at the root ofnode_modules, so if you're not using PNPM withnode-linker=hoisted, then sku can't find compile packages that are transitive dependencies (i.e. inside the PNPM virtual store).Was also seeing some flakiness in the
lint-formattest snapshots where sometimes jest was reporting that the snapshots failed with diffs that looked identical except for the text colours. This lead me to try stripping ANSI escape codes in the snapshot serializer, and this seems to have worked AFAICT.The storybook tests also decided to be flakey today, so I've increased the timeout on one of the queries we do and that seems to have helped.