Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile package detection #845

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Jun 27, 2023

The .git folder may not be available in some situations where you want to run sku. Swapping to use @manypkg/find-root instead, as this gives us the name of the package manager as well as the root directory.

EDIT: Tested in the repo where the bug was originally found, confirmed that the fix works

@askoufis askoufis requested a review from a team as a code owner June 27, 2023 05:47
@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2023

🦋 Changeset detected

Latest commit: c9cfbda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis enabled auto-merge (squash) June 27, 2023 06:15
@askoufis askoufis merged commit f254d05 into master Jun 27, 2023
4 checks passed
@askoufis askoufis deleted the fix-compile-package-detection branch June 27, 2023 06:27
@seek-oss-ci seek-oss-ci mentioned this pull request Jun 27, 2023
mrm007 pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants