Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Storybook config directory #878

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Support Storybook config directory #878

merged 3 commits into from
Aug 31, 2023

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Aug 29, 2023

For reasons outlined in my PR comment, as well as an internal confluence document, leaning into the standard .storybook configuration folder rather than pointing into sku's node modules addresses some issues and reduces the complexity of sku's storybook integration.

This includes:

  • Remove the symlinking shenanigans for preview config. Users can just write the file if they need it.
  • Remove the dummy middleware file. Users can just require/copy/symlink their existing sku dev middleware to .storybook if they want it to run during sku storybook.
  • Adds support for other config files that sku did not support

Sku still maintains control over the .storybook/main.js file as this contains critical configuration that enables storybook to work with sku's wepback setup, VE, TypeScript, etc.

This has been tested internally in both a regular app and an app within a monorepo.

@askoufis askoufis requested a review from a team as a code owner August 29, 2023 03:29
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

🦋 Changeset detected

Latest commit: 419d53a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis merged commit a70b6a6 into master Aug 31, 2023
4 checks passed
@askoufis askoufis deleted the storybook-config-dir branch August 31, 2023 00:18
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants