-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webpack-related deps, clean up some deps #885
Conversation
🦋 Changeset detectedLatest commit: 1fa0085 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It's the Babel plugin that needs to be configured to recognise |
Babel unasssert is only run during production builds/prod dev server. So it doesn't work with regular |
3958ade
to
2bc7716
Compare
Also realised that |
Found another unused dep, |
Not really sure why we had
webpack-dev-server
pinned. Also no idea howrequire-from-string
got included in this PR from a while ago. It's currently unused, and AFAICT it never was used.Also removed the
assert
dev dep and changed all imports tonode:assert/strict
in tests. There is one more usage of nodeassert
in a fixture, but that can't be changed tonode:assert
because webpack doesn't know how to load thenode:
protocol. I think adding theNodeTargetPlugin
may be the solution, but don't really want to investigate that right now.webpack-cli
dev dep fromsku
, as it's not used. It's only used in thetests
private package.traverse
dep from sku as it was unused