New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run .cjs
and .mjs
files through preset env
#906
Conversation
🦋 Changeset detectedLatest commit: 7035010 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit confused about the snapshot changes. I guess a buffer
polyfill was being bundled, but now isn't? And assert
is now no-longer externalized because the unassert
plugin is now correctly running on Braid?
For a future PR: sku exposes a tiny package that contains the extensions, e.g. |
This will affect packages like Braid and our internal component libraries as they're compiled with crackle, but also any 3rd party dependencies that are shipping
.cjs
/.mjs
source files.For now we're depending on the extension lists provided by
eslint-config-seek
, but this may change in the future.