Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report braid-design-system version via telemetry #913

Merged
merged 5 commits into from Jan 23, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Dec 15, 2023

I initially tried getting the braid version from the app's package.json dependencies, but the version could be a caret version (shows up as _32.0.0 in datadog), for example in a library, so I instead opted to fetch it from the version in the app's node_modules.

@askoufis askoufis requested a review from a team as a code owner December 15, 2023 03:18
Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: 08fe042

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/sku/telemetry/index.js Outdated Show resolved Hide resolved
packages/sku/telemetry/index.js Outdated Show resolved Hide resolved
packages/sku/telemetry/index.js Outdated Show resolved Hide resolved
@askoufis askoufis requested a review from mrm007 January 23, 2024 05:58
@askoufis askoufis merged commit f6f3507 into master Jan 23, 2024
4 checks passed
@askoufis askoufis deleted the braid-version-telemetry branch January 23, 2024 06:00
@seek-oss-ci seek-oss-ci mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants