Ensure all gitignored sku-generated files are also ignored by prettier and eslint #957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were creating the
lintIgnorePatterns
array before modifying it later on. The effect of the change should be self-explanatory based on the changed files.Note
It turns out that we were never actually linting/formatting these files anyway. This was because we are explicit about which file extensions we lint/format, but these files don't have any file extensions, so they were effectively being ignored.
I also converted a lot of the
configure
tests to use snapshots rather than asserting on each array item. These were effectively manual snapshots, which were a bit tedious to update when the time came to do so.