sku v13: Remove old configuration values and CLI arguments #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 56549d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
force-pushed
the
remove-old-config
branch
from
a4ab669
to
8ae6ae9
Compare
| const makeWebpackConfig = ({ | ||
| isIntegration = false, | ||
| port = 0, |
There was a problem hiding this comment.
Can you clarify the removal of port? Not immediately obvious from the diff
There was a problem hiding this comment.
port isn't specified anywhere makeWebpackConfig is called, and the only usage of it was in the now-deleted stringifyEnvarValues. Eventually the value ends up in a define plugin for process.env.PORT.
I don't think anyone is depending on process.env.PORT inside their app code. A high-level look at a github search for process.env.PORT aligns with that assumption.
michaeltaranto
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unused and deprecated config values and CLI args. See changesets for details.
Usage
--tenant--env--buildenvconfig. Not too concerned as the migration path should be straightforward.