Skip to content

Commit

Permalink
Ignore specific sections in deep-dive (#1438)
Browse files Browse the repository at this point in the history
  • Loading branch information
samchungy committed Feb 7, 2024
1 parent 5d14b25 commit 0969768
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,3 @@ pnpm-lock.yaml

/integration/base/

# TODO: figure out a better formatting system
docs/deep-dives/pnpm.md
5 changes: 5 additions & 0 deletions docs/deep-dives/pnpm.md
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ This migration guide assumes that your project was scaffolded with a **skuba** t
Your build pipeline may have previously mounted an ephemeral `.npmrc` with an auth token at `/workdir`.
This needs to be mounted elsewhere to avoid overwriting the new pnpm configuration stored in `.npmrc`.

<!-- prettier-ignore -->
```diff
FROM --platform=${BUILDPLATFORM:-<%- platformName %>} node:20-alpine AS dev-deps

Expand All @@ -225,6 +226,7 @@ This migration guide assumes that your project was scaffolded with a **skuba** t
+ pnpm fetch
```

<!-- prettier-ignore -->
Move the `dst` of the ephemeral `.npmrc` from `/workdir/.npmrc` to `/root/.npmrc`,
and use a [bind mount] in place of `COPY` to mount `pnpm-lock.yaml`.

Expand All @@ -243,6 +245,7 @@ This migration guide assumes that your project was scaffolded with a **skuba** t
Swap out `yarn` commands for `pnpm` commands,
and drop the unnecessary `AS deps` stage.

<!-- prettier-ignore -->
```diff
- FROM ${BASE_IMAGE} AS deps
-
Expand Down Expand Up @@ -272,6 +275,8 @@ This migration guide assumes that your project was scaffolded with a **skuba** t
ENV NODE_ENV=production
```

<!-- prettier-ignore -->

15. Modify plugins in `.buildkite/pipeline.yml`

Your build pipeline may have previously output an ephemeral `.npmrc` with an auth token on the build agent.
Expand Down

0 comments on commit 0969768

Please sign in to comment.