Align CDK DLQ Naming (#1542)

seek-oss · Apr 17, 2024 · 6600a20 · 6600a20
1 parent aa9a11d
commit 6600a20
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 10 deletions.
diff --git a/.changeset/heavy-apples-applaud.md b/.changeset/heavy-apples-applaud.md
@@ -0,0 +1,5 @@
+---
+'skuba': patch
+---
+
+template/lambda-sqs-worker-cdk: Align dead letter queue naming with Serverless template
diff --git a/template/lambda-sqs-worker-cdk/infra/__snapshots__/appStack.test.ts.snap b/template/lambda-sqs-worker-cdk/infra/__snapshots__/appStack.test.ts.snap
@@ -934,7 +934,7 @@ exports[`returns expected CloudFormation stack for dev 1`] = `
         "RedrivePolicy": {
           "deadLetterTargetArn": {
             "Fn::GetAtt": [
-              "workerqueuedlq42262778",
+              "workerqueuedeadletters83F3505C",
               "Arn",
             ],
           },
@@ -997,7 +997,7 @@ exports[`returns expected CloudFormation stack for dev 1`] = `
       },
       "Type": "AWS::SNS::Subscription",
     },
-    "workerqueuedlq42262778": {
+    "workerqueuedeadletters83F3505C": {
       "DeletionPolicy": "Delete",
       "Properties": {
         "KmsMasterKeyId": {
@@ -1006,7 +1006,7 @@ exports[`returns expected CloudFormation stack for dev 1`] = `
             "Arn",
           ],
         },
-        "QueueName": "serviceName-dlq",
+        "QueueName": "serviceName-dead-letters",
       },
       "Type": "AWS::SQS::Queue",
       "UpdateReplacePolicy": "Delete",
@@ -1976,7 +1976,7 @@ exports[`returns expected CloudFormation stack for prod 1`] = `
         "RedrivePolicy": {
           "deadLetterTargetArn": {
             "Fn::GetAtt": [
-              "workerqueuedlq42262778",
+              "workerqueuedeadletters83F3505C",
               "Arn",
             ],
           },
@@ -2039,7 +2039,7 @@ exports[`returns expected CloudFormation stack for prod 1`] = `
       },
       "Type": "AWS::SNS::Subscription",
     },
-    "workerqueuedlq42262778": {
+    "workerqueuedeadletters83F3505C": {
       "DeletionPolicy": "Delete",
       "Properties": {
         "KmsMasterKeyId": {
@@ -2048,7 +2048,7 @@ exports[`returns expected CloudFormation stack for prod 1`] = `
             "Arn",
           ],
         },
-        "QueueName": "serviceName-dlq",
+        "QueueName": "serviceName-dead-letters",
       },
       "Type": "AWS::SQS::Queue",
       "UpdateReplacePolicy": "Delete",

diff --git a/template/lambda-sqs-worker-cdk/infra/appStack.ts b/template/lambda-sqs-worker-cdk/infra/appStack.ts
@@ -32,10 +32,14 @@ export class AppStack extends Stack {
 
     kmsKey.grantEncrypt(accountPrincipal);
 
-    const deadLetterQueue = new aws_sqs.Queue(this, 'worker-queue-dlq', {
-      queueName: '<%- serviceName %>-dlq',
-      encryptionMasterKey: kmsKey,
-    });
+    const deadLetterQueue = new aws_sqs.Queue(
+      this,
+      'worker-queue-dead-letters',
+      {
+        queueName: '<%- serviceName %>-dead-letters',
+        encryptionMasterKey: kmsKey,
+      },
+    );
 
     const queue = new aws_sqs.Queue(this, 'worker-queue', {
       queueName: '<%- serviceName %>',