Skip to content

Commit

Permalink
Disable noUnusedLocals and noUnusedParameters in tsconfig (#1181)
Browse files Browse the repository at this point in the history
* Make noUnusedLocals and noUnusedParameters false

Skuba is already using Seek's ESLint config which has https://eslint.org/docs/latest/rules/no-unused-vars which works for both function and types
We don't need both tools to do the same thing.

* Add changeset

* Tweak changeset

---------

Co-authored-by: Ryan Ling <ryan@outlook.com.au>
  • Loading branch information
eddeee888 and 72636c committed May 29, 2023
1 parent 3e4dfbb commit b1d8e80
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .changeset/forty-hornets-argue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'skuba': patch
---

tsconfig: Turn off [`noUnusedLocals`](https://www.typescriptlang.org/tsconfig#noUnusedLocals) and [`noUnusedParameters`](https://www.typescriptlang.org/tsconfig#noUnusedParameters)

[SEEK's ESLint config](https://github.com/seek-oss/eslint-config-seek) has a [rule](https://eslint.org/docs/latest/rules/no-unused-vars) which works for both function and types. We do not need both tools to do the same thing and ESLint has better support for ignoring files if needed.
4 changes: 3 additions & 1 deletion config/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
"incremental": true,
"isolatedModules": true,
"moduleResolution": "node",
"resolveJsonModule": true
"resolveJsonModule": true,
"noUnusedLocals": false,
"noUnusedParameters": false
},
"extends": "tsconfig-seek"
}

0 comments on commit b1d8e80

Please sign in to comment.