Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYO Template fails with UnknownTransportError #736

Closed
HzrdIRL opened this issue Jan 12, 2022 · 4 comments · Fixed by #739
Closed

BYO Template fails with UnknownTransportError #736

HzrdIRL opened this issue Jan 12, 2022 · 4 comments · Fixed by #739

Comments

@HzrdIRL
Copy link

HzrdIRL commented Jan 12, 2022

Skuba fails to clone when using BYO template with error:

UnknownTransportError: Git remote "git@github.com:SEEK-Jobs/apply-lambda-template.git" uses an unrecognized transport protocol: "ssh"

@NathanLamSeekasia
Copy link

I saw isomorphic-git has been used since Skuba 3.15
But seems isomorphic-git doesn't support ssh?
isomorphic-git/isomorphic-git#231

@72636c
Copy link
Member

72636c commented Jan 12, 2022

Yep, it looks like I forgot to account for this use case in #599 as isomorphic-git does not support SSH clones. I think we have a couple options:

  1. Try to stick with isomorphic-git by performing the initial clone over HTTPS, then swapping out the remote URL to SSH. I'm not sure if this is a good solution since users may not have HTTPS set up properly.
  2. Revert the clone command back to the git binary or a friendly wrapper like simple-git.

@NathanLamSeekasia
Copy link

@HzrdIRL also shared another way to apply the custom template:

  1. Goto Github create a new repository and select Repository template
  2. Clone the repo into local and yarn install
  3. skuba configure

72636c added a commit that referenced this issue Jan 18, 2022
`isomorphic-git` doesn't implement SSH. Closes #736.
72636c added a commit that referenced this issue Jan 18, 2022
`isomorphic-git` doesn't implement SSH. Closes #736.
@HzrdIRL
Copy link
Author

HzrdIRL commented Jan 20, 2022

tried to clone the repo with skuba init (v 3.17.1) and it didn't work, same error :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants