Migrate select Jest options #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After many half-hearted attempts, I've finally mustered the will to get TypeScript ASTing. This extracts a blessed list of Jest options from the input `jest.config.js` and merges that with our base config. We also naively set the `--coverage` flag in `package.json#/scripts/test` when we see the `collectCoverage` option.
🦋 Changeset is good to goLatest commit: 80ef7d5 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
etaoins
approved these changes
Jun 23, 2020
| * ``` | ||
| */ | ||
| const createModuleExportsExpression = (props: Props): ts.ExpressionStatement => | ||
| ts.createExpressionStatement( |
| rootNode, | ||
| (node) => { | ||
| if ( | ||
| !ts.isExpressionStatement(node) || |
There was a problem hiding this comment.
This might read better if the whole thing was wrapped in a ! so the conditions were describing what a module export looks like instead of what it doesn’t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After many half-hearted attempts, I've finally mustered the will to get TypeScript ASTing. This extracts a blessed list of Jest options from the input
jest.config.jsand merges that with our base config. We also naively set the--coverageflag inpackage.json#/scripts/testwhen we see thecollectCoverageoption.And yes, Jest configuration is JavaScript, but this may be a better investment if we end up doing something smart with
.tssources in future.