Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude internal files from autofix commits #1074

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Conversation

72636c
Copy link
Member

@72636c 72636c commented Dec 29, 2022

Follows on from #1072 and additionally prevents .npmrc mishaps.

Follows on from #1072 and additionally prevents `.npmrc` mishaps.
@72636c 72636c requested review from a team as code owners December 29, 2022 02:38
@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022

🦋 Changeset detected

Latest commit: 62e2d20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samchungy
Copy link
Contributor

should we try and read the .gitignore for max safety?

@72636c
Copy link
Member Author

72636c commented Dec 29, 2022

@samchungy These code paths use Git.getChangedFiles under the hood, and from local testing it appears to respect .gitignore already 😌. This is an additional layer of protection as I think there are some projects where .npmrc is not .gitignored; we have one pnpm repo where this is the case.

I was actually thinking of rolling back #1072 if we're happy with this approach to avoid the unnecessary .gitignore change.

@72636c 72636c merged commit c64b057 into master Dec 29, 2022
@72636c 72636c deleted the autofix-ignore-files branch December 29, 2022 03:23
@seek-oss-ci seek-oss-ci mentioned this pull request Dec 29, 2022
72636c added a commit that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants