Skip autofix on pending Renovate Branches #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 649b06f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
reviewed
Jul 24, 2023
src/cli/lint/autofix.ts
Outdated
Comment on lines
88
to
90
| log.warn( | ||
| 'Could not find an open pull request for this branch. The autofix commit will not be applied to allow Renovate to open a pull request successfully.', | ||
| ); |
There was a problem hiding this comment.
I'll review this proper in a bit but seems perfectly reasonable. Could we also write a Buildkite warning and share next steps (i.e. fix is available but we did not push it, if the PR has since been created then you can manually rerun the step to push).
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
samchungy
changed the title
samchungy
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my run of Skuba renovate's I encountered a number of branches which had autofix commits pushed so they were stuck in Edited/Blocked.
This means that not only does the Renovate branch no longer get pushed to/updated automatically. It means I have to manually intervene and open the repository in order to see that it's stuck in Edited/Blocked.
Should we avoid pushing on skuba renovate branches unless we know there's an open PR?
Happy to be pushed back on this one.
Example
https://github.com/SEEK-Jobs/backoffice-budgets-api/tree/renovate-skuba-7.x