Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 20 #1317

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Update to Node 20 #1317

merged 9 commits into from
Nov 16, 2023

Conversation

samchungy
Copy link
Contributor

@samchungy samchungy commented Nov 16, 2023

Upgrade to Node 20

Resolves #1297

Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: 86503f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samchungy samchungy added the dino:snooze Snooze in Review Dino label Nov 16, 2023
@samchungy samchungy marked this pull request as ready for review November 16, 2023 22:52
@samchungy samchungy requested review from a team as code owners November 16, 2023 22:52
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

- `@types/node` package version
- CI/CD configuration (`.buildkite/pipeline.yml`, `Dockerfile`, etc.)

If you are updating your AWS Lambda runtime to `nodejs20.x`, consider reading the [release announcement](https://aws.amazon.com/blogs/compute/node-js-20-x-runtime-now-available-in-aws-lambda/) as there are some breaking changes with this upgrade.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For optimal performance, and to have full control over your code dependencies, we recommend bundling and minifying the AWS SDK in your deployment package, rather than using the SDK included in the runtime. For more information, see Optimizing Node.js dependencies in AWS Lambda.

hmmm

"skuba": patch
---

template/*: Update to Node 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
template/*: Update to Node 20
template: Update to Node 20

@@ -1 +1 @@
18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left the package.json engines alone in the packages as that would force consumers to update to node 20 which doesn't quite seem right?

@samchungy samchungy removed the dino:snooze Snooze in Review Dino label Nov 16, 2023
@samchungy samchungy merged commit 455f674 into master Nov 16, 2023
19 checks passed
@samchungy samchungy deleted the node20 branch November 16, 2023 23:06
@seek-oss-ci seek-oss-ci mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 20 Support
3 participants