Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document local Lambda deployment #148

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Document local Lambda deployment #148

merged 3 commits into from
Jul 14, 2020

Conversation

72636c
Copy link
Member

@72636c 72636c commented Jul 14, 2020

This was raised by @BryceKK as we don't document how to do this.

To keep it a simple single-variable matter, we now default the VERSION environment variable to local if it is not supplied. I generally don't like defaults but this one is mostly harmless, and we do a similar thing with BUILDKITE_COMMIT.

I took the opportunity to make our READMEs slightly less bad, but they are still pretty bad.

This was raised by @BryceKK as we don't document how to do this.

To keep it a simple single-variable matter, we now default the `VERSION`
environment variable to `local` if it is not supplied. I generally don't
like defaults but this one is mostly harmless, and we do a similar thing
with `BUILDKITE_COMMIT`.

I took the opportunity to make our READMEs slightly less bad, but they
are still pretty bad.
@72636c 72636c requested a review from a team as a code owner July 14, 2020 02:29
@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2020

🦋 Changeset is good to go

Latest commit: 87d23f9

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@72636c 72636c requested a review from BryceKK July 14, 2020 02:33
Copy link
Contributor

@etaoins etaoins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@72636c 72636c merged commit 5df28e9 into master Jul 14, 2020
@72636c 72636c deleted the local-lambda-deploy branch July 14, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants