Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CDK context config #1541

Merged
merged 12 commits into from
Apr 17, 2024
Merged

Replace CDK context config #1541

merged 12 commits into from
Apr 17, 2024

Conversation

samchungy
Copy link
Contributor

@samchungy samchungy commented Apr 16, 2024

Thoughts?

This is pretty clunky and involves defining config awkwardly twice.

One time in untyped JSON and then again with zod.

This cuts out both and just relies on standard TypeScript

@samchungy samchungy requested a review from a team as a code owner April 16, 2024 05:36
Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 8f9ff29

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samchungy samchungy changed the title Delete CDK context Replace CDK context config Apr 17, 2024
@samchungy samchungy merged commit aa9a11d into main Apr 17, 2024
20 checks passed
@samchungy samchungy deleted the cdk-template-config branch April 17, 2024 00:44
@seek-oss-ci seek-oss-ci mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants