Fix package manager detection #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 80df158 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samchungy
reviewed
Apr 30, 2024
packages/skuba-dive/.npmrc
Outdated
There was a problem hiding this comment.
These might break changesets
There was a problem hiding this comment.
Do you mean in consuming repos or in skuba itself?
There was a problem hiding this comment.
they did indeed break changesets, was able to get a snapshot running on a branch off this (with a dive changeset) https://github.com/seek-oss/skuba/actions/runs/8892072630
|
Snapshot is happy - are you able to take another quick look @samchungy? https://github.com/seek-oss/skuba/actions/runs/8964626049 |
samchungy
approved these changes
May 6, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1550, I found I had test snapshot diffs locally and couldn't work it out. I suspect there's funky things going on with detect-package-manager, like checking for global installs, that are somewhat unnecessary for our use cases given the strong prevalence of lockfiles with skuba projects.