fix(koa-rest-api): Use per Gantry environment concurrency group in dev #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: baba737 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I believe we should use this now Gantry uses it's own lock anyway we can't get around it. |
etaoins
approved these changes
Jul 26, 2020
There was a problem hiding this comment.
The lock is released a couple of times during a deploy which allows limited concurrency and forward progress if you're lucky. On the other hand, using a concurrency group prevents wasting a whole Buildkite task on just spinning on the DynamoDB lock. It's easy to tie up 10 agents just waiting for locks if there's a lot of merges at once.
I think this is a net win and also aligns ourselves with prod.
72636c
approved these changes
Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches the production concurrency group configuration.