Include JSON files in package bundles #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is something that should be expected to _just work_ and it didn't. JSON deserves to be a special case as it doesn't require packaging hacks as described in our migration documentation; it can be properly resolved and bundled by TypeScript's built-in `resolveJsonModules`. https://github.com/seek-oss/skuba/blob/master/docs/migrating-from-seek-module-toolkit.md#building
🦋 Changeset is good to goLatest commit: 449f012 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tobyhei
approved these changes
Aug 24, 2020
etaoins
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that should be expected to just work and it didn't. JSON deserves to be a special case as it doesn't require packaging hacks as described in our migration documentation; it can be properly resolved and bundled by TypeScript's built-in
resolveJsonModules.https://github.com/seek-oss/skuba/blob/master/docs/migrating-from-seek-module-toolkit.md#building