Upgrade to ESLint 7 + typescript-eslint 3
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You'll notice there are disabled rules. - `any` strictness seems like the highest-value change. - I'm not convinced that explicit-module-boundary-types is appropriate at this time. We could land it separately but it's still a very large change that is of questionable benefit if everything else is typed. - `no-use-before-define` asks you to do work for no benefit when dealing with functions and TypeScript types. It also can't account for certain closure patterns.
🦋 Changeset is good to goLatest commit: ca99c1e We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tobyhei
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You'll notice there are disabled rules.
anystrictness seems like the highest-value change.explicit-module-boundary-typesis appropriate at this time. We could land it separately but it's still a very large change that is of questionable benefit if everything else is typed.no-use-before-defineasks you to do work for no benefit when dealing with functions and TypeScript types. It also can't account for certain closure patterns.