Exclude files from templating based on .gitignore #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to exclude a hardcoded list of "filenames" from templating, so we didn't chug on trying to rewrite all of `.git` or `node_modules`. This easily fell out of sync and was couldn't represent complex paths. Instead, we use `.gitignore`s as a basis for which files to exclude.
🦋 Changeset is good to goLatest commit: 3d7a0f1 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
etaoins
approved these changes
Jun 7, 2020
| @@ -46,24 +46,3 @@ export const TEMPLATE_PROMPT = new Select({ | |||
| message: 'Select a template:', | |||
| name: 'templateName', | |||
| }); | |||
|
|
|||
| export const IGNORED_TEMPLATE_FILENAMES = new Set([ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to exclude a hardcoded list of "filenames" from templating, so we didn't chug on trying to rewrite all of
.gitornode_modules. This easily fell out of sync and couldn't represent complex paths.Instead, we use
.gitignores as a basis for which files to exclude.