Skip pre-build in Docker Compose service #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be generally faster across the pipelines, especially for Gantry services that already have this covered with `gantry build`. A caveat is that the Lambda deploy step may take a bit longer, but it's probably good to have a safer npm `deploy` script and we know that we need to revisit the speed of that pipeline soon anyway.
🦋 Changeset detectedLatest commit: ac102d8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
added a commit
that referenced
this pull request
Nov 2, 2020
This is required for #222 to make any sense. Co-authored-by: Hong Ket Lo <hklo@seekasia.com>
72636c
added a commit
that referenced
this pull request
Nov 2, 2020
This is required for #222 to make any sense. Co-authored-by: Hong Ket Lo <hklo@seekasia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be generally faster across the pipelines, especially for Gantry services that already have this covered with
gantry build. A caveat is that the Lambda deploy step may take a bit longer, but it's probably good to have a safer npmdeployscript and we know that we need to revisit the speed of that pipeline soon anyway.