Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-sqs-worker): Remove region from subscription example snippet #223

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

tobyhei
Copy link

@tobyhei tobyhei commented Sep 29, 2020

From https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sns-subscription.html#cfn-sns-subscription-region this field is only required for cross region subscriptions. The current value is the default implicit behavior.

@tobyhei tobyhei requested a review from a team as a code owner September 29, 2020 11:26
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2020

🦋 Changeset detected

Latest commit: ec18603

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tobyhei tobyhei merged commit 4bfeb6b into master Sep 29, 2020
@tobyhei tobyhei deleted the remove-region-from-topic-subscription-example branch September 29, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants