Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt @seek/logger #225

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Adopt @seek/logger #225

merged 4 commits into from
Oct 19, 2020

Conversation

72636c
Copy link
Member

@72636c 72636c commented Oct 1, 2020 •
edited

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2020 •
edited

🦋 Changeset detected

Latest commit: a16d775

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kosanna
kosanna approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@kosanna kosanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep cool, looks good, just need to hold on until we transfer

@72636c 72636c added the dino:snooze Snooze in Review Dino label Oct 13, 2020
@72636c 72636c changed the title Adopt @seek/logger-js Adopt @seek/logger Oct 18, 2020
@72636c 72636c marked this pull request as ready for review October 18, 2020 23:48
@72636c 72636c requested a review from a team as a code owner October 18, 2020 23:48
@72636c 72636c removed the dino:snooze Snooze in Review Dino label Oct 18, 2020
tobyhei
tobyhei approved these changes Oct 18, 2020
View reviewed changes
Copy link

@tobyhei tobyhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@72636c 72636c merged commit 644efa5 into master Oct 19, 2020
@72636c 72636c deleted the logger-js branch October 19, 2020 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobyhei tobyhei tobyhei approved these changes

@kosanna kosanna kosanna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@72636c @tobyhei @kosanna