Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak template test scripts #290

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Tweak template test scripts #290

merged 1 commit into from
Dec 8, 2020

Conversation

72636c
Copy link
Member

@72636c 72636c commented Dec 8, 2020

I've been umming and ahhing on the right approach here, as I like a fairly unopinionated test script into which the user can pass their desired flags.

Practically speaking, we have some other tooling like our package publishing pipeline which presumes that the test script is suitable for exhaustive CI testing. test:watch should be a reasonable compromise for local testing, and already has some SEEK precedence with ~46 package.json results returned from a GitHub search.

I've been umming and ahhing on the right approach here, as I like a
fairly unopinionated `test` script into which the user can pass their
desired flags.

Practically speaking, we have some other tooling like our package
publishing pipeline which presumes that the `test` script is suitable
for exhaustive CI testing. `test:watch` should be a reasonable
compromise for local testing, and already has some SEEK precedence with
~46 `package.json` results returned from a GitHub search.
@72636c 72636c requested a review from a team as a code owner December 8, 2020 13:45
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2020

🦋 Changeset detected

Latest commit: ab1c5d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@etaoins etaoins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@72636c 72636c merged commit a6984b1 into master Dec 8, 2020
@72636c 72636c deleted the template-test-scripts branch December 8, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants