Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify API health checks and smoke tests #332

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Clarify API health checks and smoke tests #332

merged 6 commits into from
Jan 26, 2021

Conversation

72636c
Copy link
Member

@72636c 72636c commented Jan 26, 2021

Resolves #116.

@72636c 72636c requested a review from a team as a code owner January 26, 2021 02:42
@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2021

🦋 Changeset detected

Latest commit: 14a5e17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

template/koa-rest-api/src/app.ts Outdated Show resolved Hide resolved
Comment on lines +1 to +2
import './register';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this explicit now because you can run into issues if ./app is not imported first.

@72636c 72636c enabled auto-merge (squash) January 26, 2021 02:56
@72636c 72636c merged commit e7254c1 into master Jan 26, 2021
@72636c 72636c deleted the healthy-smoking branch January 26, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoke testing in templates
2 participants