Rewrite dist => lib in serverless.ymls
#387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skuba's default configuration compiles to `lib`, though it's common to see `dist` and `lib` out in the wild. `skuba configure` already tries to rewire Dockerfiles to point to this output directory, and now we do the same for Serverless files. This implements globbing in our configure modules so we can match on multiple `serverless*.yml`s in the one repo.
🦋 Changeset detectedLatest commit: 3610f6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
etaoins
approved these changes
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skuba's default configuration compiles to
lib, though it's common to seedistandlibout in the wild.skuba configurealready tries to rewire Dockerfiles to point to this output directory, and now we do the same for Serverless files.This implements globbing in our configure modules so we can match on multiple
serverless*.ymls in the one repo.