ci: remove yarn cache for worker dev deps image

[samchungy]

The workers don't need to run yarn install after this step so we might as well remove the yarn cache associated with it.

In my testing -> this reduced the size of images by half

[changeset-bot]

🦋 Changeset detected

Latest commit: 0422fab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
skuba	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[72636c]

😍

Does the same apply to our non-worker templates, or is the cache required for the yarn install --production step seen elsewhere?

[samchungy]

Yeah the cache is required if yarn --offline is used, which is what the APIs seem to use when building the prod image

[72636c]

Should we && yarn cache clean off of e.g. this then?

skuba/template/koa-rest-api/Dockerfile

Line 8 in caeb867

RUN yarn install --ignore-optional --ignore-scripts --non-interactive --offline --production

[samchungy]

Should we && yarn cache clean off of e.g. this then?

skuba/template/koa-rest-api/Dockerfile

Line 8 in caeb867

RUN yarn install --ignore-optional --ignore-scripts --non-interactive --offline --production

hmmm 🤔 I don't know Docker well enough, does the image layer from that step contribute to the size of the final image? If it doesn't then maybe not?

[72636c]

D'oh, that's me overlooking that we only copy node_modules over. We could include this in the Hello World template though, thoughts? https://github.com/seek-oss/skuba/blob/master/template/greeter/Dockerfile

[samchungy]

D'oh, that's me overlooking that we only copy node_modules over. We could include this in the Hello World template though, thoughts? https://github.com/seek-oss/skuba/blob/master/template/greeter/Dockerfile

Hmmm maybe, depends on that repos usage I guess